monkeytypegame / monkeytypegame/monkeytype

Support for alternative Korean encoding types

Open
#7,455 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
20.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

Did you clear cache before opening an issue?
  • I have cleared my cache
Is there an existing issue for this?
  • I have searched the existing open and closed issues
Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

No response

Account config

No response

Current Behavior

Monkeytype only expects NFC-encoded (precomposed) Hangul (Korean writing system), and if NFD-encoded (decomposed) Hangul is entered, it is marked as incorrect.

Expected Behavior

NFD-encoded Hangul should be normalized before comparison.

Steps To Reproduce
  1. Use an input method which inserts decomposed Hangul Jamo
  2. Monkeytype will mark everything entered as incorrect
Environment
  • OS: CachyOS (6.18.7-2-cachyos)
  • Browser: Firefox
  • Browser Version: 147.0.1
Anything else?

https://github.com/user-attachments/assets/eaae606e-8e6d-4e7b-98b4-459fe8d5734f
Confirming the issue is not with input itself, as everything renders correctly in zen mode.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue in Firefox with an input method that inserts decomposed Hangul Jamo, then trace the input comparison path to find where normalization should occur. Done means NFD-encoded Hangul is accepted equivalently to NFC-encoded Hangul, with a regression test covering the comparison.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, internationalization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.