monkeytypegame / monkeytypegame/monkeytype

Arabic letters not connecting when on Safari

Open
#5,909 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug waiting for update
Dominant language
TypeScript
Stars
20.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

Did you clear cache before opening an issue?
  • I have cleared my cache
Is there an existing issue for this?
  • I have searched the existing issues
Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

ZiadA

Account config

No response

Current Behavior

The arabic letters are not joining like they are supposed to when there are characters next to them. Making it very unreadable. Like so:

Screenshot 2024-09-22 at 20 40 09

Expected Behavior

The letters are supposed to join like so:

Screenshot 2024-09-22 at 20 40 53

The way I managed to get the word to render correctly is by using safari's inspect element tool and adding a zero width joiner before the letter in the beginning of the word, before and after the letter in them middle, and after the word in the end. However, I have no idea if that is a good solution.

Steps To Reproduce
  1. Go to monkeytype.com on safari on a mac computer.
  2. Change the language to Arabic.
Environment
  • OS: MacOS Sonoma 14.4.1
  • Browser: Safari
  • Browser Version: 17.4.1
Anything else?

This might be considered a bug in safari instead of a bug in monkeytype, I am not sure.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the problem on monkeytype.com in Safari 17.4.1 on macOS Sonoma, then inspect the Arabic language selection and text-rendering entry points. Compare the result with another browser and determine whether the issue is in the site or Safari; done means Arabic letters render joined correctly in Safari without manual zero-width joiners.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, internationalization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.