monkeytypegame / monkeytypegame/monkeytype

Accuracy calculation not working properly in Vietnamese

Open
#4,218 26 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stuck
Dominant language
TypeScript
Stars
20.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

Did you clear cache before opening an issue?
  • I have cleared my cache
Is there an existing issue for this?
  • I have searched the existing issues
Does the issue happen when logged in?

Yes

Does the issue happen when logged out?

Yes

Does the issue happen in incognito mode when logged in?

Yes

Does the issue happen in incognito mode when logged out?

Yes

Account name

No response

Account config

No response

Current Behavior

When typing in Vietnamese, we have to typing 2 or 3 letters in other to making 1 correct letter
And it seems like monkeytype calculate those characters as incorrect

Example: when we typing "ước" it's actually the combination of

  • <"uo" and "s" and "w" and "c" > of in Telex, having prefix as "uo" and other characters can be in different ordinal
  • <"uo" and "7" and "2" and "c"> in VNI, also having prefix as "uo" and other characters can be in different ordinal

(Telex and VNI is 2 most common Vietnamese typing method) and monkeytype calculate that we have 2 errors

Expected Behavior

Base on the example above
Monkeytype should count those input as "Correct" and not "Incorrect" as it's now

Steps To Reproduce
  1. Open Monkeytype
  2. Select Vietnamese as typing language
  3. Typing in with Telex or VNI encode
Environment
  • OS: Windows 11
  • Browser: Google Chrome
  • Browser Version: 12.0.5615.138 (Official Build) (64-bit)
Anything else?

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the issue with Vietnamese selected and Telex or VNI input, comparing the composed characters with the accuracy result. Trace the existing typing and accuracy handling until the composition is accounted for, then verify that the example produces no incorrect-character count.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, internationalization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.