monad-developers / monad-developers/ultrafuzz

Controller refresh authenticates plan-time prompts against the unsealed run-root plan.json

Open
#1,003 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
85
Forks
18
Avg merge
11h 10m
Merged PRs (30d)
194

Description

Found while landing #1002; pre-existing on main, not introduced by that fix.

currentControllerPromptBindings (packages/runtime/src/smithers.ts, formerly currentControllerTasks) authenticates each retained prompt snapshot against a row read from <runRoot>/plan.json — the unsealed run-root copy — rather than the sealed controls/plan.json. verifyDynamicRuntimeMaterialization already uses the sealed copy (workflow-integrity.ts:605); the refresh path does not.

An adversarial probe forged a rendered_prompts row with an attacker-chosen rendered_prompt_snapshot_path and a matching rendered_prompt_digest. Both the fix branch and clean main bound the forged prompt into the refreshed controller source and both still admitted the run:

ADV22: ACCEPTED spec= .../runs/adv22/prompt-snapshots/forged.md
ADV22 admission after forged plan: true []

The digest gate is self-referential: it checks the snapshot against a digest recorded in the same unauthenticated document. Because resume is ungated, the forged prompt is bound and read before any gated command runs, so a later tasks.json divergence would not save it either.

Related, same root: the #990 deferred-prompt exemption is an unauthenticated bypass. Setting deferredPromptGroups plus an arbitrary renderedPromptPath in runtime-base-tasks.json skips the digest gate entirely on both trees.

Both route through currentControllerBaseTasks trusting the run-root smithers/runtime-base-tasks.json rather than the sealed controls/runtime-base-tasks.json — that selection is #991's.

Fix direction: authenticate the run-root plan row against controls/plan.json before rebinding, and give the deferred-prompt exemption a positive authentication rather than a skip.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in packages/runtime/src/smithers.ts at currentControllerPromptBindings and currentControllerBaseTasks, then compare their plan and runtime-base-tasks selection with verifyDynamicRuntimeMaterialization in workflow-integrity.ts:605. Reproduce the ADV22 forged-prompt probe and trace the deferred-prompt path. Done means refresh authenticates against controls/plan.json and the deferred-prompt exemption has positive authentication rather than skipping the digest gate.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.