Navigate doesn't clear search params
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.9k
- Forks
- 190
- Avg merge
- 12h 50m
- Merged PRs (30d)
- 3
Description
Calling navigate('/foo') will leave search params in place unless there's a replacement search string after the /foo. I don't know why I'd want search to persist between different pages. And if I did, I could always do it manually with navigate(`/foo?${search}`).
This caused me issues where I have a couple routes that use similarly named search params, but whose values absolutely shouldn't carry over. So now I have to do navigate('/foo?dummy') in all of my navigation logic to prevent this behavior.
This really shouldn't be the default that people have to fight with.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the navigate('/foo') entry point described in the issue and trace how the destination URL is assembled when no replacement search string is provided. Done means navigation to another path clears the existing search parameters by default while an explicitly supplied search string still works; the payload names no files or tests to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100