mohebifar / mohebifar/react-native-copilot
Pass (at least some) config inside start() function instead of copilot()
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.4k
- Forks
- 428
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
Some configurations, like "verticalOffset" or "labels" may depend on the state of a component or context.
For example, a language selection that changes without a full-reload happening after.
Describe the solution you'd like
It makes sense to me to pass those kind of mutable configs/settings inside the start() function, which is invoked in the component, therefore having the capabilities that React Hooks provides.
Describe alternatives you've considered
I propose to keep the current behaviout, but also allow the configs to be passed inside the start() function, and as a consequence, copilot to update the labels/offsets/other as soon as the passed state changes.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect how configuration currently flows through copilot() and the component's start() function. Determine which mutable settings, such as verticalOffset and labels, need to be accepted by start() and updated when component state changes; done means those values can change without a full reload.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react-native, typescript
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100