modular / modular/stack-pr

Landed part of the stack gets lost after subsequent submit

Open
#53 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
569
Forks
43
PR merge metrics
No merged PRs in 30d

Description

I'm not sure if this is by design or if I'm doing something wrong, so wanted to ask. I have this stack:

Screenshot 2024-12-06 at 23 10 49

After I stack-pr land the first PR, then did some rebasing and stack-pr submit again, the landed commit got removed from the stack in all subsequent PRs:
Screenshot 2024-12-06 at 23 12 08

Losing this piece of context feels unfortunate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the workflow described with stack-pr land, a rebase, and stack-pr submit, using the linked LLVM pull requests as context. Trace how the landed portion is handled during submission; done means the landed commit remains represented in subsequent stack pull requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.