Base branch change on 'no change' part of the stack
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 569
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
Hey! Thanks for releasing stack-pr, I'm really enjoying it ❤️
I do have a question/comment – when I amend a local commit in the middle of the stack and then run stack-pr submit, I'd expect that unchanged commits/PRs (at least those coming before the amended one) shouldn't have to be updated on GH. Is this fair?
Right now this doesn't seem to be the case. Details below re: the "base branch" part, but I think this is a part of a more general topic of checking if something's no-op and reducing the noise in PRs.
Details:
I have the following stack: https://github.com/artempyanykh/marksman/pull/366
The sequence of steps is:
1] stack-pr submit
2] amend the local commit corresponding to 2nd from the top #368
- stack-pr submit
I see that 2nd from the bottom got its base branch updated
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the stack-pr submit flow and reproduce the sequence described: submit a stack, amend the second commit from the top, then submit again. Trace how base branches are updated for unchanged commits before the amended one; done means those no-op PRs are not updated, while the amended portion still is.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github, python
- Domain
- cli, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100