modular / modular/stack-pr

Land Whole Stack

Open
#45 7 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Python
Stars
569
Forks
43
PR merge metrics
No merged PRs in 30d

Description

At present, the default stack-pr land and suggested stack-pr land -B [branch-name]~[stack-count] -H [branch-name] from stack-pr view leads me to believe these commands should land ALL entries in the stack. Instead, it processes the oldest entry in the stack and then stops. There are no errors and the local digraph state is correct. I'd expect either of the aforementioned land commands to land the whole stack rather than one at a time.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior with the default stack-pr land command and with the stack-pr land -B [branch-name]~[stack-count] -H [branch-name] command suggested by stack-pr view. Trace the land command's handling of the stack and verify that completion processes every stack entry rather than stopping after the oldest one, while preserving the correct local digraph state.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.