Not an issue, feedback on my hacking
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.2k
- Forks
- 394
- Avg merge
- 3d 5h
- Merged PRs (30d)
- 7
Description
Hello Modesty,
For what its worth, I combined your shell scripts into a single script using the Test Anything Protocol.
Feel free to use if interested.
Output looks like this:
not ok # dc: output doesn't match expected output.
not ok # de: output doesn't match expected output.
not ok # ef: output doesn't match expected output.
not ok # fd: output doesn't match expected output.
not ok # nd: output doesn't match expected output.
not ok # or: output doesn't match expected output.
not ok # pa: output doesn't match expected output.
not ok # sc: output doesn't match expected output.
not ok # va: output doesn't match expected output.
# 100% agencies failed totally or partially: dc de ef fd nd or pa sc va
All diffs(1) are stored locally in out.diff files, and cleaned up as per your initial logic.
Note: I reorganised the directories to fit my needs (basically to have side-by-side the inputs and outputs). Basically flattening out the /form subdirectories into a same location. Let me know if unclear.
Cheers, Don
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the attached pdf2json.sh.txt alongside the project's existing shell scripts. Determine whether the maintainer wants the Test Anything Protocol output, local out.diff files, and flattened input/output directories adopted; the message provides no concrete acceptance criteria or requested change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- cli, tooling
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 15/100