modelscope / modelscope/ms-swift
DSA 不支持 cp 吗
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 15.7k
- Forks
- 1.7k
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 136
Description
Checklist / 检查清单
- I have searched existing issues, and this is a new feature request. / 我已经搜索过现有的 issues，确认这是一个新的 Feature Request。
Feature Request Description / Feature Request 描述
cp > 1 会报错， self.context_parallel_size == 1
AssertionError: Currently context parallelism is not supported by DSAttention!
Pull Request / Pull Request 信息
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the assertion "Currently context parallelism is not supported by DSAttention" and tracing how self.context_parallel_size is set and checked. Determine the existing DSAttention context-parallel entry points and relevant tests, then verify that cp > 1 works without the assertion and that coverage demonstrates the supported behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- distributed-systems, machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100