modelscope / modelscope/ms-swift

[Feature] Support vLLM arguments (vllm_tensor_parallel_size, vllm_data_parallel_size, vllm_max_model_len) in 'swift sample'

Open
#7,253 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement stale
Dominant language
Python
Stars
15.7k
Forks
1.7k
Avg merge
1d 16h
Merged PRs (30d)
136

Description

Describe the feature

The swift sample command currently does not support vLLM-specific parameters, such as:

  • vllm_tensor_parallel_size
  • vllm_data_parallel_size
  • vllm_max_model_len

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the swift sample command entry point and trace how its arguments reach vLLM. Check how the three named parameters are parsed and passed through; done means all three arguments are accepted by swift sample and affect the vLLM sampling configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.