modelcontextprotocol / modelcontextprotocol/typescript-sdk

Typechecking should fail on returning {} for all requests

Open
#42 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug P3 potentially close ready for work
Dominant language
TypeScript
Stars
13.4k
Forks
2.2k
Avg merge
3d 15h
Merged PRs (30d)
4

Description

Right now, AFAICT this is considered valid, probably because of Result (the base definition) being a valid return type.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the TypeScript definitions for Result, since the issue identifies it as the base return type, and trace the request-handler typechecking path. Add a regression case showing that returning {} for every request is rejected, then confirm that valid Result-based returns still typecheck.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.