modelcontextprotocol / modelcontextprotocol/typescript-sdk

PKCE verification: 2025-11-25 requires refusing when `code_challenge_methods_supported` is absent, which conflicts with the #832 / #992 resolution

Open
#2,831 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
13.4k
Forks
2.2k
Avg merge
3d 15h
Merged PRs (30d)
4

Description

Summary

This is a follow-up to #832 and #992, not a report that the check is missing — it is deliberately
permissive, and this is about the spec moving underneath that decision.

#992 made startAuthorization treat an absent code_challenge_methods_supported as "assume PKCE is
supported", to unblock Azure AD and AWS Cognito, whose OIDC discovery documents omit the field while
the providers do support S256. The reasoning in #832 was explicitly "if the list isn't present,
assume it's there, and rely on the requests later failing if you send PKCE parameters that the AS
doesn't support."

The MCP specification has since taken the opposite position. The 2025-11-25 revision's
"Authorization Code Protection" section requires clients to verify PKCE support from
authorization-server metadata and to refuse when the field is absent — stated separately for RFC
8414 metadata and for OpenID Connect Discovery, the latter precisely because OIDC provider metadata
does not define the field. It also tells OIDC providers to publish it for MCP compatibility.

The 2025-06-18 revision does not mention code_challenge_methods_supported at all, so this
requirement post-dates #992. The SDK currently implements the #992 behavior and therefore does not
satisfy the 2025-11-25 requirement.

Current behavior

@modelcontextprotocol/client 2.0.0, startAuthorization:

if (metadata.code_challenge_methods_supported &&
    !metadata.code_challenge_methods_supported.includes(AUTHORIZATION_CODE_CHALLENGE_METHOD)) {
  throw new Error(`Incompatible auth server: does not support code challenge method ...`);
}

The leading truthiness check makes an absent field a no-op. At the schema level the field is
.optional() on OAuthMetadataSchema, and OpenIdProviderDiscoveryMetadataSchema picks that same
optional field, so an OIDC document without it parses clean and proceeds to authorization.

Reproduction

Serve authorization-server metadata with no code_challenge_methods_supported (issuer,
authorization_endpoint, token_endpoint, response_types_supported: ["code"]) and run the
auth() flow. It completes; nothing is raised or surfaced.

Why this is worth revisiting rather than closing

The #832 rationale holds for the common case and I am not arguing it should be reverted: PKCE
parameters are still sent, so a server that supports PKCE but omits the advertisement remains fully
protected. The gap is narrower than "no PKCE".

What the current behavior cannot do is distinguish that server from one that ignores code_challenge
outright, and it gives an embedder no signal that the distinction was unresolvable. "Rely on the
requests later failing" does not hold for this specific failure mode: an authorization server with
no PKCE support does not reject a request carrying code_challenge, it ignores the parameter, and
the flow succeeds with the protection silently absent.

Possible resolutions

  1. Surface the condition without changing the flow — a documented callback, a warning, or a field on
    the returned discovery state — so embedders can apply their own policy. This preserves #992 and is
    the smallest change.
  2. An opt-in strict mode that refuses, defaulting to today's behavior.
  3. Refuse as the spec requires, with an opt-out for the OIDC case. Spec-correct, but reintroduces the
    #832 breakage as the default.
  4. Document the deviation from 2025-11-25 explicitly, so embedders know the check is theirs to make.

We implemented (1) plus (2) at the gateway layer and would be happy to send a PR for whichever
direction you prefer here.

Environment

@modelcontextprotocol/client 2.0.0 (latest at time of filing).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with startAuthorization, OAuthMetadataSchema, OpenIdProviderDiscoveryMetadataSchema, and the auth() reproduction described in the issue. First resolve which of the four proposed policies is wanted; done means the selected behavior for an absent code_challenge_methods_supported field is implemented and its deviation or strictness is documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, security
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.