modelcontextprotocol / modelcontextprotocol/inspector

No visible test for Windows path separators in launcher/CLI argument forwarding

Open Beginner friendly
#2,416 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

chore v2
Dominant language
TypeScript
Stars
10.9k
Forks
1.5k
Avg merge
6h 17m
Merged PRs (30d)
151

Description

Which version line?

v2 — current (@modelcontextprotocol/inspector@latest)

Which client?

CLI

Inspector version

2.7.0 (git tag) — static code-review finding, not run locally

Node version

N/A — static code review, no live run performed

Operating system (and browser, for the web client)

N/A — static code review

Transport

Not applicable / never connected

MCP server under inspection

N/A — this is a static code-review finding against the 2.7.0 tag source (clients/launcher/src/parse-launcher-argv.ts and CLI arg handling), not a live reproduction against a running MCP server.

Steps to reproduce

Found via static review of the 2.7.0 tag source, not a live run.

  1. parseLauncherArgv and the CLI's arg handling work on raw argv slices.
  2. Nothing in the reviewed tests exercises a Windows-style path with backslashes as a forwarded server command/arg.
  3. The project's own history shows a "Windows CI/gate fixes" pass this cycle — worth confirming it covered argument content, not just the runner environment.

I have not run this on a Windows machine to observe an actual failure; flagging the absence of this test case itself.

Expected behavior

A test exists asserting that a Windows-style path with backslashes, passed as a forwarded server command or argument, survives launcher/CLI argument parsing intact.

Actual behavior

No visible test covers this case; the "Windows CI/gate fixes" pass this cycle appears to have addressed the runner environment but not necessarily argument content specifically.

Suggested fix: add a test case in the launcher/CLI argv-parsing suite that passes a Windows-style path (with backslashes) as a forwarded argument and asserts it round-trips correctly.

Logs, errors, or screenshots

No response

Already prototyped a fix?

No response

Before you submit
  • I searched existing issues and this is not a duplicate.
  • This is not a security vulnerability report (those go through the private advisory process).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with clients/launcher/src/parse-launcher-argv.ts and the CLI argument-handling code, then locate the launcher/CLI argv-parsing test suite. Add coverage for a Windows-style path with backslashes passed as a forwarded command or argument, and verify that it round-trips intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
cli, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.