modelcontextprotocol / modelcontextprotocol/experimental-ext-interceptors

Sink interceptor type

Open
#16 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
C#
Stars
23
Forks
14
Avg merge
1d 17h
Merged PRs (30d)
1

Description

In implementing the TypeScript SDK we ran into the following issue. The SEP defines the interceptor types as:

  /**
   * Interceptor operation type
   */
  type: "validation" | "mutation";

The C# SDK also implements a type called sink:

    /// <summary>
    /// Fire-and-forget, non-blocking, non-mutating interceptor type for reacting to context
    /// (logging, telemetry, avatar animation, voice-mode triggers, etc.) without affecting
    /// the interaction. Sink interceptors run in parallel and failures are swallowed.
    /// </summary>
    [JsonStringEnumMemberName("sink")]
    Sink,

The TypeScript SDK implements sink for compatibility with the C# SDK.

We should either officially add sink to the spec/SEP, or remove it from all SDKs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by comparing the SEP interceptor definition with the TypeScript and C# SDK implementations, then determine whether the sink type should be added to the specification or removed from all SDKs. Done means the decision is documented and the specification and SDK behavior are consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, typescript
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.