modelcontextprotocol / modelcontextprotocol/csharp-sdk
Cache authorization policy lookups for IMcpServerPrimitives
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.5k
- Forks
- 814
- Avg merge
- 9d 19h
- Merged PRs (30d)
- 4
Description
The authorization filters added by #733 looks up policies for IMcpServerPrimitives every request. This used to also be done by the authorization middleware, but .NET 7 introduced IAuthorizationPolicyProvider.AllowsCachingPolicies which makes it possible to cache at least some authorization policy. We could add an Items dictionary to IMcpServerPrimitives to track the cached policy similar to the Items dictionary #733 adds to the RequestContext<TParams>, or we could use a ConditionalWeakTable<IMcpServerPrimitive, AuthorizationPolicy?>.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the authorization filters added by #733 and inspect IMcpServerPrimitives, RequestContext, and IAuthorizationPolicyProvider.AllowsCachingPolicies. Compare the proposed Items dictionary and ConditionalWeakTable approaches, then verify that eligible authorization policies are reused across requests without changing authorization behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- authorization
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100