modelcontextprotocol / modelcontextprotocol/csharp-sdk

Update ProtectedResourceMetadata to use IList/ISet instead of List

Open Beginner friendly
#678 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement needs confirmation
Dominant language
C#
Stars
4.5k
Forks
814
Avg merge
9d 19h
Merged PRs (30d)
4

Description

Unlike most of our other JSON DTOs, we use List<string> instead of something like IList<string> or ISet<string>.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the ProtectedResourceMetadata DTO and compare its collection properties with the other JSON DTOs in the C# SDK. Update the metadata collections to use the intended IList/ISet abstractions, then run the relevant SDK tests or validation available for JSON DTO serialization to confirm the change is compatible.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
api
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
64/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.