moby / moby/vpnkit

Compilation error due to "Unbound module Ethernet__Ethernet_wire"

Open
#630 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
1.2k
Forks
214
PR merge metrics
No merged PRs in 30d

Description

I am trying to build the repository from the master branch (as there are no binary distributions) on a Mac,
but there are references to data structures that are no more present in "ethernet" {>= "3.0.0"}:

https://github.com/moby/vpnkit/blob/ee2e5c0f7fd3100715957af2d6b497fbf90806db/src/hostnet/hostnet_dns.ml#L256

I also had to comment out these lines:
https://github.com/moby/vpnkit/blob/master/dune#L14-L17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Mac build from the master branch with ethernet >= 3.0.0, then inspect src/hostnet/hostnet_dns.ml at the cited reference and the dune lines that required commenting out. Done means the repository builds without those dune edits and without the Unbound module Ethernet__Ethernet_wire error.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.