go: vpnkit.Connection should have a Close()
Nobody has claimed this yet.
- Dominant language
- OCaml
- Stars
- 1.2k
- Forks
- 214
- PR merge metrics
- No merged PRs in 30d
Description
This is needed for cleanup. I think the protocol requires us to keep the physical connection open because the fids are tied to it and the resources are tied to the fids, but a future non-9P implementation should support a better API... so we could think about being future proof.
See https://github.com/linuxkit/linuxkit/pull/2701#discussion_r150187924
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Go definition of vpnkit.Connection and read the linked linuxkit discussion about the proposed API and 9P resource constraints. Done means Connection exposes the requested cleanup operation with behavior consistent with the current protocol limitations and the future-proofing concerns described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend-api-design, networking
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100