moby / moby/vpnkit

Fails to parse IPv6 addresses in configuration

Open
#179 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
OCaml
Stars
1.2k
Forks
214
PR merge metrics
No merged PRs in 30d

Description

@dsheets reports that this error appears:

com.docker.slirp: [ERROR] failed to parse com.docker.driver.amd64-linux/slirp/dns: Failed to parse configuration: Ipaddr.Parse_error("invalid character ':' at 4", "2001:8b0:cb40:3495:3291:8fff:fe02:8cde")

We should use Ipaddr.of_string to parse IPv4 and v6 addresses. Probably the only annoying thing is the specification of the port. Perhaps we should use a separate line for that, rather than stick it on the end of the IP address? Some people use [addr]:port also there exist v6 zones like addr%iface. A newline might be the best terminator.

References:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the com.docker.driver.amd64-linux/slirp/dns configuration parser and inspect how addresses are currently read. Check how Ipaddr.of_string can handle IPv4 and IPv6, then establish how ports and IPv6 zones should be represented; done means the reported IPv6 address parses without the colon error.

Written by the indexing model from the issue text.

Assessment

Tech stack
ocaml
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.