Consider generating a fresh snapshot with "--force-new-cluster" flag
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.7k
- Forks
- 676
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 6
Description
#574 adds a "-force-new-cluster" flag that removes all other members from the cluster. I think there would be some advantages to generating a fresh snapshot instead that does not include the other members (and marks them as removed). It would prevent members from contacting previous members of the cluster while catching up with the log entries, and remove the possibility of a loss of quorum while newly joining members are catching up.
#580 has an implementation of this approach. We decided not to go ahead with this at the moment, because it's not a priority. In the future we may want to come back to this, especially if we find any problems with the current approach.
See https://github.com/docker/swarm-v2/pull/580#issuecomment-218891461 and the comment below for a discussion of the pros and cons.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading #574 for the existing --force-new-cluster behavior and #580 for the proposed fresh-snapshot implementation. Review the linked discussion and comment thread to understand the trade-offs; the work is complete when the approach is agreed and its implementation and validation criteria are defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- distributed-systems
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100