moby / moby/swarmkit

increase allowed amount of characters for config & secret name

Open
#2,918 7 comments 14 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
3.7k
Forks
676
Avg merge
4d 9h
Merged PRs (30d)
6

Description

Currently both names are max 64 characters long.

We have a naming-scheme with versioning in the name and hit often this limit. Is there a reason for only allowing 64 chars? Can this easily be increased? Would a patch be accepted?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the validation for configuration and secret names and any tests covering the current 64-character limit. Determine an acceptable replacement limit from the existing behavior and project context; done means the limit is consistently increased for both names and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.