moby / moby/swarmkit

Clean up maybe unused CA root update code

Open
#2,641 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
3.7k
Forks
676
Avg merge
4d 9h
Merged PRs (30d)
6

Description

https://github.com/docker/swarmkit/pull/2238 was added to account for edge cases when renewing TLS certificates on the worker. This was needed mainly because the update mechanisms were different for the manager vs the agent.

https://github.com/docker/swarmkit/pull/2336 fixed that issue, so in theory https://github.com/docker/swarmkit/pull/2238 should be deletable, but there should be more stress testing on root CA rotation before actually removing it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read pull requests #2238 and #2336 to compare the worker and manager certificate update paths. Stress-test root CA rotation first; done means confirming the older edge-case handling is redundant and can be removed without breaking certificate renewal.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.