Address node promotion inconsistencies
Open
@anshulpundir is already working on this.
Since Mar 14, 2018.
- Dominant language
- Go
- Stars
- 3.7k
- Forks
- 676
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 6
Description
As a part of node promotion, we set the desired state of the node to manager in the control api. Then, role_manager reconciles this node after receiving a node update. The reconciliation marks this node as manager in the store. However, its addition to the raft memberlist only happens when the node actually joins. So, for a brief period, the state in the store is inconsistent with the state in raft memberlist.
One way to address this is to make node promotion wait for the node to join raft memberlist.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.