moby / moby/swarmkit

Remove references to voting in allocator

Open
#2,121 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
3.7k
Forks
676
Avg merge
4d 9h
Merged PRs (30d)
6

Description

There is some code in the allocator with naming that references voting and ballots. I don't think this is the right analogy for what this code is doing. No decision is being made based on a majority or plurality of these "votes". Rather, it's a mechanism from preventing the task state from advancing until all allocators have taken the actions they need to take.

I feel we should change the naming so it's less confusing.

cc @ijc25

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the allocator code and search for names that refer to voting or ballots, then trace their uses before changing terminology. Done means the naming describes the mechanism without implying a majority or plurality decision, while preserving the allocator behavior; run the relevant allocator tests afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
distributed-systems
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.