agent: tasks being rejected too early
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- go
- Domain
- distributed-systems
Research direction
Start in daemon/cluster/executor/container/container.go around line 46, then compare the equivalent swarmkit package. Trace where container configuration is validated during controller resolution and how the prepare stage handles the task; done means invalid container configuration is rejected during preparation rather than reported as a controller-resolution failure.
Written by the indexing model from the issue text.
Description
There are cases where we are seeing error messages as follows:
Sep 13 10:09:47 docker-p-02 dockerd[754]: time="2016-09-13T10:09:47.916070937Z" level=error msg="controller resolution failed" module=agent task.id=8imf1rsmtw1revwems0qe8klz
Sep 13 10:09:47 docker-p-02 dockerd[754]: time="2016-09-13T10:09:47.916083220Z" level=error msg="failed to start taskManager" error="invalid bind mount source, source path not found: /srv/cloudsql" module=agent
These tasks end up in the rejected state, as they should but the failure is due to an invalid container configuration, rather than a controller resolution.
The problem lies in https://github.com/docker/docker/blob/master/daemon/cluster/executor/container/container.go#L46 (also the equivalent swarmkit package). The validation of the container configuration should happen in the prepare stage, rather than when resolving the controller.
cc @aaronlehmann
- Dominant language
- Go
- Stars
- 3.7k
- Forks
- 676
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 6
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from moby/swarmkit
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
Similar issues
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
blinklabs-io/bursa#904 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
yanet-platform/ipfw-go#129 ·
-
bug confmap/provider/googlesecretmanagerprovider needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
open-telemetry/opentelemetry-collector-contrib#51273 · 2 comments ·
-
bug: AI Gateway client filter lists "Unknown" twice when NULL and literal Unknown clients coexist Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100