moby / moby/swarmkit

Swarm manager should time out idle agent connections

Open
#1,275 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
3.7k
Forks
676
Avg merge
4d 9h
Merged PRs (30d)
6

Description

The manager should time out old connections that have not have recent activity. One possible source of these connections is a bug like #1274. Another example of where this could happen is an agent with a flaky network that isn't able to hold open a connection, and keeps opening new ones in retry attempts.

Since agents send a periodic heartbeat, connections with no recent activity should be considered stale and they should be cleaned up.

In the current state of affairs, these connections live on forever unless something happens at the TCP level to terminate them, and the manager will eventually have its resources exhausted.

I'm not sure whether GRPC supports this, but if it doesn't we should request it. It's an important feature.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named. Begin by locating the swarm manager's agent-connection handling and checking whether gRPC provides an idle-connection timeout. Done means stale connections are cleaned up based on heartbeat inactivity; if gRPC lacks support, the issue should lead to a support request.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, grpc
Domain
backend, distributed-systems
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.