Internode healthcheck shouldn't change service package
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3.7k
- Forks
- 676
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 6
Description
For the node health checking to be compatible with GRPC health checking, the package name cannot change. It must be package grpc.health.v1.
https://github.com/docker/swarmkit/pull/957/files#diff-1131a495e9663ab73eadbeb399282a92R12
The big use case here is GRPC load balancing, but I am not sure yet how this will integrate, so registering two health check services on separate package paths may be okay.
cc @abronan @aaronlehmann
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the package declaration shown in pull request #957 and trace the internode health-check service entry point. Confirm that the service uses package grpc.health.v1 without breaking the existing health-check behavior, then verify whether the separate service paths can coexist for gRPC health checking.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, grpc
- Domain
- api, distributed-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100