spdy_test.go:146: No error closing bad stream
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 149
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
With Go 1.12.2 on Fedora Rawhide x86_64, commit 6480d4af844c189cf5dd913db24ddd339d3a4f85:
Testing in: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build/src
PATH: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build/bin:/builddir/.local/bin:/builddir/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
GOPATH: /builddir/build/BUILD/spdystream-6480d4af844c189cf5dd913db24ddd339d3a4f85/_build:/usr/share/gocode
GO111MODULE: off
command: go test -buildmode pie -compiler gc -ldflags "-X github.com/docker/spdystream/version=0 -X github.com/docker/spdystream/version.commit=6480d4af844c189cf5dd913db24ddd339d3a4f85 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '"
testing: github.com/docker/spdystream
github.com/docker/spdystream
--- FAIL: TestSpdyStreams (0.01s)
spdy_test.go:146: No error closing bad stream
FAIL
exit status 1
FAIL github.com/docker/spdystream 0.272s
(The test is run in a chroot with no network access.)
I don't see the stream being closed twice in the test to actually trigger the error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with TestSpdyStreams in spdy_test.go, especially line 146, and reproduce the failure using the reported Go 1.12.2 Fedora Rawhide environment and no-network chroot. Trace the bad stream's close behavior to determine why the expected error is absent; done means the test's intended close-error assertion is resolved and the test passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100