moby / moby/spdystream

Automatically chunk data sent to Stream.WriteData

Open
#31 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
149
Forks
59
PR merge metrics
No merged PRs in 30d

Description

Stream.WriteData always constructs exactly one spdy DataFrame, which causes an error when the data byte array has length greater than 16MB (the spdy max frame data size).

I'm proposing that when large (>16MB) data is sent to WriteData, we should automatically split this into multiple data frames. This change would cause a disconnect between WriteData and ReadData as currently implemented, as ReadData always expects a single data frame.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementations of Stream.WriteData and ReadData, then inspect how a single SPDY DataFrame is constructed and consumed. Define the behavior for payloads larger than the 16MB frame limit and verify that writing and reading chunked data remain compatible without disconnects.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.