moby / moby/moby

Build: pin dependencies by hash

Open
#51,637 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Go
Stars
72.1k
Forks
19.2k
Avg merge
1d 17h
Merged PRs (30d)
164

Description

Description

Currently, the dependencies such as containerd and runc are not pinned by the hash:

https://github.com/moby/moby/blob/a1836eb2834010c69cbf6de80095508f084fa6b4/hack/dockerfile/install/containerd.installer#L13-L19

These dependencies are also consumed by docker-ce-packaging here: https://github.com/docker/docker-ce-packaging/blob/7e726fa319c261676d06b6ae10c04a3df80e4c48/static/Makefile#L43-L58

Tasks:

Previous attempts:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing hack/dockerfile/install and hack/dockerfile/cli.sh, along with the linked Dockerfile and packaging Makefile references. Compare the completed buildx and Dockerfile changes with the reverted pull request and previous attempts before choosing the remaining approach. Done means the remaining dependencies are pinned by hash through Dockerfile.rego or the specified ADD/COPY changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
build-system, devops, security
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.