moby / moby/moby

client: look if we need DisplayJSONMessages and DisplayJSONMessagesStream

Open
#51,145 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/go-sdk module/client release-blocker
Dominant language
Go
Stars
72.1k
Forks
19.2k
Avg merge
1d 18h
Merged PRs (30d)
164

Description

Description

The client currently has these functions, but they may be redundant with the changes from that PR; we need to look if the changes of that PR would make them redundant and if we have a proper replacement for code using them so that we can remove them (and not having to carry them forward in the new client module)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the client’s DisplayJSONMessages and DisplayJSONMessagesStream functions alongside the changes in PR 50935. Determine whether those changes make the functions redundant, identify proper replacements for callers, and confirm whether both functions can be removed from the new client module.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.