Remove `container.OS`
@vvoland is already working on this.
Since Nov 18, 2024.
- Dominant language
- Go
- Stars
- 72.1k
- Forks
- 19.2k
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 164
Description
Description
https://github.com/moby/moby/pull/48855/commits/f4c39e633d5b77c6d70b85c7494970cd14920f9b deprecated OS field in the Container struct that is used to persist the on-disk state in favor of a Platform field that contains a full OCI platform information.
A best-effort migration was also added, which attempts to fill the new ImagePlatform field based on the old OS value and the container image.
At some point, we should remove the old field and the migration completely.
However, this will mean that containers created before v28 will be missing the platform information, so that probably needs some time/or a clearer documentation on our support for upgrades.
Also add a warning to the release notes:
TODO: Containers created before v28 need to be recreated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.