moby / moby/moby

c8d: preserve attestations when loading a single platform from an image

Open
#48,761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/images containerd-integration kind/enhancement
Dominant language
Go
Stars
72.1k
Forks
19.2k
Avg merge
1d 17h
Merged PRs (30d)
164

Description

Description

Just a quick placeholder / reminder: when loading an image from a tar, we should try to preserve attestations where possible; from https://github.com/moby/moby/pull/48718#issuecomment-2434797011

one thing I did not verify is what we do with attestations; do we preserve those when saving (and loading)?

Currently we only preserve them if no platform was selected. Technically we could also load a corresponding attestation, but I don't think we can do that with client.Import - we'd need a lower level code for this.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing image loading from a tar and compare the existing no-platform behavior with single-platform loading through client.Import. Investigate the lower-level loading path mentioned in the issue for accessing a corresponding attestation. Done means preserving attestations where possible when a single platform is selected.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.