moby / moby/libnetwork

Support QinQ networks

Open
#2,597 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
2.2k
Forks
875
PR merge metrics
No merged PRs in 30d

Description

Seems that macvlan_network.go does not support QinQ. Docker nativley supports this. When setting the parent to something like eth0.10.100 an error is thrown "Errorf("required interface name format is: name.vlan_id, ex. eth0.10 for vlan 10, instead received %s", linkName)" from macvlan_setup.go parseVlan function.

QinQ Seems to not be supported. Would be a Useful feature. Currently preventing me from implementing this libary. Is there a sugested work around?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in macvlan_network.go and inspect the parseVlan function in macvlan_setup.go, where eth0.10.100 is rejected by the current interface-name validation. Trace how the parent interface is parsed and configured, then verify that QinQ parent names are accepted without breaking existing VLAN handling. Done means a QinQ parent such as eth0.10.100 no longer produces the format error.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.