moby / moby/libnetwork

DOCKER-USER chain and DOCKER-INGRESS cleanup

Open
#1,852 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement/code-cleanup help wanted
Dominant language
Go
Stars
2.2k
Forks
875
PR merge metrics
No merged PRs in 30d

Description

The 2 chains requires a specific configuration ordering where the DOCKER-USER is always on top of the DOCKER_INGRESS.
The current code handles the configuration of the 2 in separate functions and code path, up to the point that bugs like: https://github.com/docker/libnetwork/issues/1827 are being exposed.
The patch: https://github.com/docker/libnetwork/pull/1845 addressed the specific issue, but looks like there can be some code cleanup that can be done to ensure that there is only one chain programming codepath that will always ensure correct ordering without the need to do subsequent rule delete/create to fix it

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the separate DOCKER-USER and DOCKER-INGRESS configuration paths, then read the linked libnetwork issue 1827 and pull request 1845. Done means one chain-programming path consistently preserves DOCKER-USER before DOCKER-INGRESS without subsequent rule deletion and recreation.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
networking
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.