CI Integration test misses testing the controller in agent mode
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.2k
- Forks
- 875
- PR merge metrics
- No merged PRs in 30d
Description
Current CI test using dnet seems not enable the agent mode. After looking at the dnet code, I do not think the current dnet implementation supports forming a gossip cluster.
To start libnetwork controller in its agent mode, it requires if keysAvailable && !c.isDistributedControl() [1]. The keys are generated by the event EventNetworkKeysAvailable.
Since dnet does not issue such event, it prevents the dnet controller enters its agent mode.
Is my understanding correct? Thanks.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the current CI integration test that uses dnet, then read controller.go around lines 313-327 and trace the EventNetworkKeysAvailable path. Confirm whether the test can exercise agent mode and document or add coverage for that mode; done means the CI test explicitly verifies the controller behavior in agent mode.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- networking, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100