port already allocated
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 2.2k
- Forks
- 875
- PR merge metrics
- No merged PRs in 30d
Description
We met "port already allocated" problem in our docker environment. It always happened after docker-daemon restarts abnormally or machine restarts abnormally.
I read the related code, and found a possible bug about this.
In the source code, the process of creating a container using port mapping is like below:
- create container
- create sandbox
- create endpoint
- allocate ports
- update driver endpoint store
- join sandbox
- update sandbox store
And the restore process after the daemon restarts is like below:
- restore port mapping based on driver endpoint restore
- clean up sandbox based on sandbox store
- clean up endpoint based on endpoint store
In the creating process, if the docker daemon or the machine restarts abnormally between step 5 and step 7 which truely happened in our environment, after docker daemon restarts, the port mapping would be restored in step 1 of restore process and will not be released in step 2 of restore process because sandbox was not updated, which causing ports leak.
I have made a simple fix which has been tested in our environment. I will make a PR later. Looking forward to your suggestions!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test path is named. Trace the container-creation sequence around port allocation and endpoint or sandbox restoration after an abnormal daemon restart; done means stale port mappings are released when the sandbox was not updated, without causing valid mappings to be lost.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, go
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100