moby / moby/libnetwork

Labels aren't passed to remote plugins

Open
#1,490 3 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
2.2k
Forks
875
PR merge metrics
No merged PRs in 30d

Description

If I create a network with

docker network create -d calico calico-test2 --label hi=ho

Then my remote plugin doesn't get passed the label that I set. This is confusing and I can't see documentation for it.

This is the JSON that it gets sent:

{u'NetworkID': u'8d7cea8fd765a9886cff8970da95b9c93e8cce31866ded3c27ab0691943966ce', u'IPv4Data': [{u'Pool': u'172.19.0.0/16', u'Gateway': u'172.19.0.1/16', u'AddressSpace': u'LocalDefault'}], u'IPv6Data': [], u'Options': {u'com.docker.network.enable_ipv6': False, u'com.docker.network.generic': {}}}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the docker network create -d calico calico-test2 --label hi=ho command and inspect the remote-plugin network creation request. Trace where network labels should enter the JSON shown in the issue; done means the remote plugin receives the requested label and coverage verifies the behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.