Hyperkit Build from Release Tarball Fails Assertions Related to Git Version
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 3.7k
- Forks
- 336
- PR merge metrics
- No merged PRs in 30d
Description
Makefile issue: https://github.com/moby/hyperkit/blob/adc4ea8641b9a5804951fb0116ad4784a86ced40/Makefile#L1-L2
Release tarballs are not git repositories. This causes failed assertions when connecting with VPNKit.
Assertion failed: (sizeof(VERSION_SHA1) == sizeof(init_msg.commit) + 1), function vpnkit_connect
, file src/lib/pci_virtio_net_vpnkit.c, line 324.
Failed Assertion: https://github.com/moby/hyperkit/blob/adc4ea8641b9a5804951fb0116ad4784a86ced40/src/lib/pci_virtio_net_vpnkit.c#L323-L325
This causes problems for the homebrew build of hyperkit: https://github.com/Homebrew/homebrew-core/issues/85232
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Makefile lines 1-2 and the assertion in src/lib/pci_virtio_net_vpnkit.c lines 323-325. Build Hyperkit from a release tarball, then exercise the VPNKit connection to reproduce the version-length mismatch. Done means the release-tarball build no longer triggers this assertion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100