Rename JSONArgsRecommended to ExecArgsRecommended

Open
#4,977 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
go
Domain
build-system, tooling

Research direction

Inspect frontend/dockerfile/linter/ruleset.go at the linked rule definition and search the repository for JSONArgsRecommended references. Rename the rule consistently to ExecArgsRecommended, and confirm that all references use the new name.

Written by the indexing model from the issue text.

Description

RUN/CMD/ENTRYPOINT have an "exec form" and a "shell form". The JSONArgsRecommended lint rule talks about JSON arguments, but this is more commonly referred to as exec form, so I think this lint rule should be renamed.

https://github.com/moby/buildkit/blob/69d230aa55af4066dabbbe86c50c79aeb40a8401/frontend/dockerfile/linter/ruleset.go#L58-L64

Dominant language
Go
Stars
10.3k
Forks
1.5k
Avg merge
1d 23h
Merged PRs (30d)
48

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from moby/buildkit

All issues in moby/buildkit

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.