toStream should produce an iterable, for better compatiblity with other libs
Open
Nobody has claimed this yet.
PR welcome!
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 130
- PR merge metrics
- No merged PRs in 30d
Description
Just spent some time trying to get it to work with the npm package rx but it didn't work. I only noticed I had to use RxJS 5 (npm package rxjs) when I looked at the relevant tests file.
With RxJS 5 the examples work fine.
The errors were:
(toStream)
Uncaught TypeError: Object is not iterable
at getIterable (rx.all.js:2706)
at FromObservable.subscribeCore (rx.all.js:2634)
at FromObservable.tryCatcher (rx.all.js:63)
at setDisposable (rx.all.js:2082)
(fromStream)
Cannot read property fn of undefined
(forgot to save stack trace)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading test/observable-stream.js, especially the examples using RxJS 5, then trace the toStream and fromStream entry points. Reproduce the reported errors with the rx package and verify that toStream produces an iterable and fromStream no longer fails in the reported usage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100