mobxjs / mobxjs/mobx-utils

Upgrade tsconfig target to es6?

Open
#329 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.2k
Forks
130
PR merge metrics
No merged PRs in 30d

Description

Can we upgrade the tsconfig target to es6, and remove "useDefineForClassFields": true?

It helps parse time, runtime performance and transpiled size to use es6 features natively rather than the transpiled versions.

This saves 300 lines of code in the transpiled output.

I'm not sure if there's any minimum target environment for this project, but es6 has been around a long time now, and there's a benefit to bumping the target.

Happy to send a PR if this is workable.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the repository's tsconfig and determine the project's minimum supported runtime, since the issue leaves that target unresolved. Check the build or test commands and compare the generated output before and after the configuration change. Done means ES6 is the target, the useDefineForClassFields option is removed, and the project still builds and tests successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.