createTransformer contains duplicated code
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 130
- PR merge metrics
- No merged PRs in 30d
Description
Another here:
https://github.com/mobxjs/mobx-utils/blob/4bf881dc1cfc15b162ad750a267949ac8323c967/src/create-transformer.ts#L62-L71
https://github.com/mobxjs/mobx-utils/commit/887d928afd6540893ea83e78600a7930483bfb93 and https://github.com/mobxjs/mobx-utils/commit/43805db436636a14a25ca2107ab262d8344ab0b4 might be incorrectly merged in https://github.com/mobxjs/mobx-utils/commit/9fac6ae8bddb896a7a3be520a84f54eb698354a3.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting src/create-transformer.ts at lines 51-57 and 62-71, then compare commits 887d928, 43805db, and 9fac6ae to understand how the duplication was introduced. Consolidate the duplicated createTransformer logic while preserving the behavior from the relevant commits, and verify that the resulting implementation remains consistent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100