addHiddenProp should use 'defineProperty' from 'mobx'
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.2k
- Forks
- 130
- PR merge metrics
- No merged PRs in 30d
Description
When useProxies is set to "ifavailable", createTransformer may throw error in some use cases (see repro). This issue should be related to mobxjs/mobx#2876
Repro: https://codesandbox.io/s/mobx-defineproperty-forked-q4q6k?file=/src/index.ts
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked CodeSandbox reproduction and trace createTransformer to addHiddenProp. Check how defineProperty is currently obtained and how MobX exposes it; done means the reproduction no longer throws when useProxies is set to "ifavailable".
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100