mobxjs / mobxjs/mobx-react-devtools

[Discussion] Mobx Devtools vs React Devtools inconsistent highlighted updates

Open
#82 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.2k
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Hi,

I'm getting inconsistent results when using the highlight updates feature of Mobx React Devtools and React Devtools.

Using Mobx-React-Devtools the Mobx components are only highlighted twice (when they render the first time and after being updated when I click the update button:

mobx-devtools-1

But when I use React Devtools the Mobx components are always being highlighted suggesting that they are always being rendered:

2018-02-10_1653

Is this expected?

Here is a link to the sample project on CodeSandBox in case you want to try it out.

I've also noticed that on both Mobx components there's an update method being called every single time:

performance mobx

I'm mentioning it since I don't see something similar for the sample React PureComponent that I'm using without Mobx.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked CodeSandbox sample and reproduce the inconsistent highlight updates in Mobx-React-Devtools and React Devtools. Compare the highlighted renders and the reported update calls, then determine whether the behavior is expected or indicates a bug; the issue does not name a source file or test to update.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.