mobxjs / mobxjs/mobx-devtools

Observable property name is not show in diff popover using mobx v5

Open
#70 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
502
Forks
34
PR merge metrics
No merged PRs in 30d

Description

When using mobx v3, the popover that shows object diff shows the property name (isLoading) correctly as below:

mobx3

When upgrading to mobx v5 is show the class name followed by a number (ArticlesStore@9) instead of the property name

mobx5

Is this a know bug in devtools?

Or is a problem with mobx v5?

What code i can look for it?

The Popover code is here but i could not find where this.props.path value is defined

This is the original code where i found this behavior and the diff upgrading mobx to v5

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/frontend/TabChanges/LObjDiff.jsx at the referenced use of this.props.path, then compare it with the MobX v3 and v5 behavior shown in the linked example and upgrade commit. Trace where the path is defined and confirm that the diff popover displays the observable property name rather than the MobX class name and number.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react
Domain
devtools, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.