mltframework / mltframework/shotcut
Key framing causes an instant crash when the key framing panel is positioned away from it's default positon (Issue revisited)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 15.2k
- Forks
- 1.5k
- Avg merge
- 11h 27m
- Merged PRs (30d)
- 5
Description
This is a second post to an issue where clicking on the key frame button to any filter property caused a crash on the Microsoft windows version of Shotcut that was tough to be initially resolved by rebooting and reinstalling, however the problem has shown up again and after looking it up I found a thread on the forum with the exact problem and what caused it (moving the key framing panel elsewhere from it's original position)
It seems to happen only with with v23.05.14 and v23.05.07 since the issue is absent from v22.12.21 and lower (the betas and alphas between v23.05.07 and v22.12.21 weren't tested) both installation and portable versions were tested.
The steps to reproduce :
- Download any released version post v22.12.21
- Dock the key frame panel in any other place that isn't with the Timeline panel
- Add any supported video/image format file to the playlist
- Drag such said file to the timeline and add a filter that has a property that can be key framed
- Click on the key frame button along the property
As previously said the problem was temporarily resolved with v23.05.14 thanks to the first post ( where I was not aware that docking the key framing panel was what caused it so I blamed it on a general use of key framing) however booting up my laptop a few hours afterwards and the problem has appeared again along with the previous solution no longer working, no error was shown during the installations to test out which release caused this bug.
My specs : (all drivers are up to date)
- CPU : 11th Gen Intel core i5-11400H @2.70Ghz
- GPU : NVIDIA GeForce GTX 1650 & Intel UHD Graphics
- RAM : 16 Gb DDR4
- Storage : 256 SSD
- OS : Windows 10 64bit 22H2 (latest)
This is by no means a major issue since a solution is known and the responses to the linked thread shows that the bug wasn't able to be reproduced on the developers's machines, this post is made to inform what versions of Shotcut has this bug and the abnormal temporary fix that stopped working.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the crash on Windows using the issue's docking and key-framing steps, and read the linked Shotcut forum thread for the known context. The fix is complete when moving the key framing panel away from the Timeline no longer causes a crash when adding a key frame.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100