Avoid setting up an explicit python path on shogun
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 107
- Forks
- 46
- PR merge metrics
- No merged PRs in 30d
Description
On shogun install file, when the user is using, e.g: virtualenv, this kind of CMAKE configuration will override the users configuration for python environment.
Is it really necessary? In my case, the system-wide python didn't have numpy, but my active virtualenv had and it was not finding it. By removing the definition of PYTHON_INCLUDE_DIR, PYTHON_EXECUTABLE:FILEPATH and PYTHON_PACKAGES_PATH variables it worked as expected.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with libraries/shogun_install.sh at the linked CMake configuration around line 31, and compare its Python path settings with an active virtualenv. Remove or revise the explicit PYTHON_INCLUDE_DIR, PYTHON_EXECUTABLE:FILEPATH, and PYTHON_PACKAGES_PATH settings so the active environment can be used, then verify that Shogun installation finds its Python dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, python, shell
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100